-
Notifications
You must be signed in to change notification settings - Fork 2
If install script installs a tag/branch/commit, pin workflows to that #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Previously, the install script was just downloading the examples as of that commit. Now we pin usage to that as well.
|
This PR has been staged at https://f5d6677a.astro-site-testing.pages.dev. It has been updated for commit e363674. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR enhances the install script to pin workflow references to the specified tag, branch, or commit being installed, ensuring consistency between the downloaded examples and their reusable workflow references.
- Adds a new function
update_reusable_workflow_referencesto pin workflow references after downloading - Updates the integration test to verify that workflow references are properly pinned
- Improves shell script quoting and adds validation for pinned references
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| install.py | Adds workflow reference pinning functionality and integrates it into the install process |
| test_install.py | Adds comprehensive tests for the new pinning functionality and updates existing tests |
| test_install.sh | Improves shell script with proper quoting and adds validation for pinned workflow references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This PR has been staged at https://4fa535a4.static-site-tools-testing.pages.dev. It has been updated for commit e363674. |
|
This PR has been staged at https://608f6a8f.jekyll-site-testing.pages.dev. It has been updated for commit e363674. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Previously, the install script was just downloading the examples as of that commit. Now we pin usage to that as well.