WIP: Chore: Update to iced 0.12 #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdachse
commented
Feb 16, 2024
| KeyCode::Up => { | ||
| fn handle_input(&mut self, key: Key) -> Command<Message> { | ||
| match key { | ||
| Key::Named(Named::ArrowUp) => { |
There was a problem hiding this comment.
Here I wasn't sure what we really wanted... this is verbose, but typesafe :)
|
Hey @nerdachse thanks a lot for the PR, I moved it to #80 and fixed the issue you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet done, as
As you can see, only one item is always shown (and you can see the scrollbar is not tall enough)
I've played around a bit, but it has been years since I experimented with
icedand I couldn't figure out why it's not behaving as wanted.Pretty self-explanatory.
I am opening this PR nonetheless because it may help as a base for someone else, or even me, when I have time to work on this again.
Apart from opening the PR I want to take a moment and say: Thank you! I love onagre!