Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker configs and documentation #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Jul 18, 2024

fixes #70

  • update how to run the jar file
  • Update Dockerfile
  • Update documentation with how to run using docker
    Resolves [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.69%. Comparing base (712d495) to head (108f44f).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
- Coverage     45.01%   43.69%   -1.32%     
- Complexity      130      135       +5     
============================================
  Files            16       16              
  Lines          1213     1332     +119     
  Branches        146      157      +11     
============================================
+ Hits            546      582      +36     
- Misses          600      684      +84     
+ Partials         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lincmba lincmba requested a review from ndegwamartin July 22, 2024 10:19
@lincmba lincmba force-pushed the update_docker_configs_and_documentation branch 2 times, most recently from 07c5b2f to f007919 Compare July 23, 2024 09:08
 fixes #70
 - update how to run the jar file
- Update documentation with how to run using docker
@lincmba lincmba force-pushed the update_docker_configs_and_documentation branch from f007919 to 108f44f Compare August 28, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation
2 participants