Restrict random number generator to Bound exclusive

onaio · Nov 20, 2024 · 0a9839a · 0a9839a
1 parent a70d0cb
commit 0a9839a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/efsity/src/main/java/org/smartregister/command/QuestionnaireResponseGeneratorCommand.java b/efsity/src/main/java/org/smartregister/command/QuestionnaireResponseGeneratorCommand.java
@@ -457,7 +457,7 @@ private static String aiGenerated(
   }
 
   public static <T extends Number> double getRandomNumber(T bound) {
-    return random.nextDouble() * bound.doubleValue();
+    return random.nextDouble() * (bound.doubleValue() - 1);
   }
 
   public static <T extends Number> double getRandomNumber(T origin, T bound) {
@@ -468,7 +468,7 @@ public static <T extends Number> double getRandomNumber(T origin, T bound) {
       throw new IllegalArgumentException("Origin must be less than bound");
     }
 
-    return originValue + random.nextDouble() * (boundValue - originValue);
+    return originValue + random.nextDouble() * (boundValue - (originValue + 1));
   }
 
   public static class Constants {