-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Affected Issue(s): Fixes when try to run within Windows OS environment (
#268) * Affected Issue(s): Fixes when try to run within Windows OS environment Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Renamed an entry in `.env` from `username` to `user_name` to accomodate usage within Windows OS (there is a default OS env var %username% within Windows OS) 2. Added `python-magic-bin` to the `requirements.txt`, to resolve issue of: ``` ImportError: failed to find libmagic. Check your installation ``` (Possibly only happens in Windows OS, not really sure) * Affected Issue(s): Small fix on `requirements.txt` Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Only add `python-magic-bin` as one of the requirements if the `sys_platform` is Windows. * Affected Issue(s): Fixed tests env Resolves sid-indonesia/it-team#313 What this commit has achieved: 1. Renamed env var `username` to `user_name` in `pytest.ini`. 2. Corrected the order of default values in the `README.md` of `importer`.
- Loading branch information
1 parent
5a78668
commit 11b7fc3
Showing
4 changed files
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters