move deletion to outside the condition

onaio · Apr 25, 2024 · f3beb92 · f3beb92
1 parent 1fc65e8
commit f3beb92
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/importer/main.py b/importer/main.py
@@ -627,9 +627,6 @@ def group_extras(resource, payload_string, group_type):
         else:
             del_indexes.append(GROUP_INDEX_MAPPING["product_image_index"])
 
-        for x in reversed(del_indexes):
-            del payload_obj["resource"]["characteristic"][x]
-
     elif group_type == "inventory":
         (
             _,
@@ -732,12 +729,12 @@ def group_extras(resource, payload_string, group_type):
         else:
             del_indexes.append(GROUP_INDEX_MAPPING["inventory_donor_index"])
 
-        for x in reversed(del_indexes):
-            del payload_obj["resource"]["characteristic"][x]
-
     else:
         logging.info("Group type not defined")
 
+    for x in reversed(del_indexes):
+        del payload_obj["resource"]["characteristic"][x]
+
     payload_string = json.dumps(payload_obj, indent=4)
     return payload_string