Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 add physical type #120

Merged
merged 4 commits into from
Feb 1, 2024
Merged

115 add physical type #120

merged 4 commits into from
Feb 1, 2024

Conversation

TraciebelWairimu
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #115

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@Wambere
Copy link
Contributor

Wambere commented Jan 31, 2024

@dubdabasoduba @f-odhiambo confirming that both type and physicalType are limited to only Building and Jurisdiction, is this correct?

@dubdabasoduba
Copy link
Member

dubdabasoduba commented Feb 1, 2024

@Wambere @TraciebelWairimu these columns can hold other items

PhysicalType - https://hl7.org/fhir/R4B/valueset-location-physical-type.html
Type - https://terminology.hl7.org/3.1.0/ValueSet-v3-ServiceDeliveryLocationRoleType.html - This list might be too long maybe we can provide a way on the CSV to provide the required options.

I am okay with merging this then we can handle the items on the comments later

@Wambere
Copy link
Contributor

Wambere commented Feb 1, 2024

@dubdabasoduba ok, let me create a separate issue for that

@Wambere Wambere merged commit 2b5e47c into main Feb 1, 2024
4 checks passed
@Wambere Wambere deleted the 115-add-physical-type branch February 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update the location importer template to use Location.type and not Location.physicalType
3 participants