161 link location inventories #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wambere
force-pushed
the
161-link-location-inventories
branch
from
fa375b6 to
0163795
Compare
pld
requested changes
Jun 6, 2024
importer/main.py
Outdated
Comment on lines
779
to
812
| entry = { | ||
| "flag": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://smartregister.org/codes", | ||
| "code": "22138876", | ||
| "display": "Supply Inventory List", | ||
| } | ||
| ], | ||
| "text": "Supply Inventory List", | ||
| }, | ||
| "date": supply_date, | ||
| "item": {"reference": "Group/" + inventory_id}, | ||
| } | ||
| entries.append(entry) | ||
|
|
||
| except KeyError: | ||
| entry = { | ||
| "entry": [ | ||
| { | ||
| "flag": { | ||
| "coding": [ | ||
| { | ||
| "system": "http://smartregister.org/codes", | ||
| "code": "22138876", | ||
| "display": "Supply Inventory List", | ||
| } | ||
| ], | ||
| "text": "Supply Inventory List", | ||
| }, | ||
| "date": supply_date, | ||
| "item": {"reference": "Group/" + inventory_id}, | ||
| } | ||
| ] |
There was a problem hiding this comment.
can you reduce the duplication here?
pld
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #161
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide