Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uploader] Uploader tool enhancement #279

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

FikriMilano
Copy link
Contributor

@FikriMilano FikriMilano commented Aug 26, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes:

  1. Update local resource with id from server [Uploader] Update local resource with id returned from server #274
  2. Add client_credentials grant type support [Uploader] client_credentials grant type is not supported #277

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@FikriMilano FikriMilano self-assigned this Aug 26, 2024
@FikriMilano FikriMilano changed the title Update local resource with id from server [Uploader] Update local resource with id from server Aug 26, 2024
@FikriMilano FikriMilano requested a review from Wambere August 26, 2024 13:28
@Wambere Wambere force-pushed the 274-update-local-resource-with-id-from-server branch from d268fd6 to 1347aea Compare August 26, 2024 16:53
@FikriMilano FikriMilano enabled auto-merge (squash) August 28, 2024 08:23
@FikriMilano FikriMilano changed the title [Uploader] Update local resource with id from server [Uploader] Uploader tool enhancement Aug 28, 2024
@FikriMilano FikriMilano merged commit 615a691 into main Aug 28, 2024
4 checks passed
@FikriMilano FikriMilano deleted the 274-update-local-resource-with-id-from-server branch August 28, 2024 15:14
@FikriMilano FikriMilano linked an issue Aug 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uploader] client_credentials grant type is not supported
2 participants