Upload FHIR resources #86
Conversation
| ArrayList<JSONObject> resourceObjects = new ArrayList<>(); | ||
| for(String f: resourceFiles){ | ||
| FctFile inputFile = FctUtils.readFile(f); | ||
| // TODO check if file contains valid fhir resource |
There was a problem hiding this comment.
Thinking of adding a prompt here to let the publisher continue or stop once they see if their file is valid or not
There was a problem hiding this comment.
Yea I think we should default stop if any file is not valid and fail everything before upload start if any is not valid, but you can pass a flag on invocation that's like "do not validate"
There was a problem hiding this comment.
cool, created separate issue for this
| if(resource.has("id")){ | ||
| resourceID = resource.getString("id"); | ||
| } else { | ||
| resourceID = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
generate a random UUID incase this is not provided
There was a problem hiding this comment.
do we need to seed Java's random lib when before calling this? I don't remember
| ArrayList<JSONObject> resourceObjects = new ArrayList<>(); | ||
| for(String f: resourceFiles){ | ||
| FctFile inputFile = FctUtils.readFile(f); | ||
| // TODO check if file contains valid fhir resource |
There was a problem hiding this comment.
Yea I think we should default stop if any file is not valid and fail everything before upload start if any is not valid, but you can pass a flag on invocation that's like "do not validate"
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #29
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide