Merge pull request #979 from onaio/fix-charts-list-has-no-split-attri…

…bute-error

fix list has no split attribute exception in chart_tools.py

onadata/libs/tests/utils/test_chart_tools.py

@@ -310,6 +310,20 @@ def test_get_choice_label_with_single_select(self):
 
         self.assertEqual(get_choice_label(choices, string), [string])
 
+    def test_get_choice_label_with_list_label(self):
+        choices = [{
+            'control': {},
+            'name': 'Western Rural',
+            'label': 'Western Rural'
+        }, {
+            'control': {},
+            'name': 'Western Urban',
+            'label': 'Western Urban'
+        }]
+        string = ['Western Rural']
+
+        self.assertEqual(get_choice_label(choices, [string]), [string])
+
     def test_get_choice_label_for_multi_select(self):
         pam = "PAM"
         croix_rouge = "Croix Rouge"

onadata/libs/utils/chart_tools.py

@@ -107,7 +107,7 @@ def get_choice_label(choices, string):
     """
     labels = []
 
-    if string and choices:
+    if string and isinstance(string, six.string_types) and choices:
         label = find_choice_label(choices, string)
 
         if label:
@@ -122,6 +122,9 @@ def get_choice_label(choices, string):
             # but a missing label, use string
             if None in labels:
                 labels = [string]
+    elif isinstance(string, list) and string:
+        # most likely already translated
+        labels = string
     elif not choices:
         labels = [string]