fix: OsmUploadQuestion fields

Closes XLSForm#752
onaio · Jan 28, 2025 · 0847036 · 0847036
1 parent 854ffe6
commit 0847036
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/pyxform/question.py b/pyxform/question.py
@@ -62,7 +62,7 @@
 SELECT_QUESTION_FIELDS = (*QUESTION_FIELDS, *SELECT_QUESTION_EXTRA_FIELDS)
 
 OSM_QUESTION_EXTRA_FIELDS = (constants.CHILDREN,)
-OSM_QUESTION_FIELDS = (*QUESTION_FIELDS, *SELECT_QUESTION_EXTRA_FIELDS)
+OSM_QUESTION_FIELDS = (*QUESTION_FIELDS, *OSM_QUESTION_EXTRA_FIELDS)
 
 OPTION_EXTRA_FIELDS = (
     "_choice_itext_id",

diff --git a/tests/test_osm.py b/tests/test_osm.py
@@ -2,6 +2,9 @@
 Test OSM widgets.
 """
 
+from pyxform.builder import create_survey_element_from_dict
+from pyxform.question import OsmUploadQuestion
+
 from tests.pyxform_test_case import PyxformTestCase
 
 expected_xml_output = """
@@ -54,3 +57,9 @@ def test_osm_type_with_list_underscore_name(self):
             """,
             xml__contains=[expected_xml_output],
         )
+
+    def test_osm_type_to_json_dict(self):
+        osm_dict = {"type": "osm", "name": "osm_road", "label": "Road"}
+        osm_question = create_survey_element_from_dict(osm_dict)
+        self.assertTrue(isinstance(osm_question, OsmUploadQuestion))
+        self.assertEqual(osm_question.to_json_dict(), osm_dict)