Make core API call non-blocking

oncokb · Oct 3, 2024 · 5662fa1 · 5662fa1
1 parent dafac59
commit 5662fa1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/src/main/webapp/app/service/firebase/firebase-gene-review-service.ts b/src/main/webapp/app/service/firebase/firebase-gene-review-service.ts
@@ -36,6 +36,8 @@ import { EvidenceApi } from 'app/shared/api/manual/evidence-api';
 import { createGeneTypePayload, isGeneTypeChange } from 'app/shared/util/core-gene-type-submission/core-gene-type-submission';
 import { GeneTypeApi } from 'app/shared/api/manual/gene-type-api';
 import { flattenReviewPaths, useLastReviewedOnly } from 'app/shared/util/core-submission-shared/core-submission-utils';
+import { notifyError } from 'app/oncokb-commons/components/util/NotificationUtils';
+import { STOP_REVIEW_IF_CORE_SUBMISSION_FAILS } from 'app/shared/feature-flags';
 
 export class FirebaseGeneReviewService {
   firebaseRepository: FirebaseRepository;
@@ -180,31 +182,50 @@ export class FirebaseGeneReviewService {
         }
       }
     } catch (error) {
-      throw new SentryError('Failed to create evidences when accepting changes in review mode', { hugoSymbol, reviewLevels, isGermline });
+      const sentryError = new SentryError('Failed to create evidences when accepting changes in review mode', {
+        hugoSymbol,
+        reviewLevels,
+        isGermline,
+      });
+      if (STOP_REVIEW_IF_CORE_SUBMISSION_FAILS) {
+        throw sentryError;
+      } else {
+        console.error(sentryError);
+      }
     }
 
     try {
       if (geneTypePayload) {
         await this.geneTypeClient.submitGeneTypeToCore(geneTypePayload);
       }
     } catch (error) {
-      throw new SentryError('Failed to submit evidences to core when accepting changes in review mode', {
+      const sentryError = new SentryError('Failed to submit evidences to core when accepting changes in review mode', {
         hugoSymbol,
         reviewLevels,
         isGermline,
       });
+      if (STOP_REVIEW_IF_CORE_SUBMISSION_FAILS) {
+        throw sentryError;
+      } else {
+        console.error(sentryError);
+      }
     }
 
     try {
       if (hasEvidences) {
         await this.evidenceClient.submitEvidences(evidences);
       }
     } catch (error) {
-      throw new SentryError('Failed to submit evidences to core when accepting changes in review mode', {
+      const sentryError = new SentryError('Failed to submit evidences to core when accepting changes in review mode', {
         hugoSymbol,
         reviewLevels,
         isGermline,
       });
+      if (STOP_REVIEW_IF_CORE_SUBMISSION_FAILS) {
+        throw sentryError;
+      } else {
+        console.error(sentryError);
+      }
     }
 
     let updateObject = {};

diff --git a/src/main/webapp/app/shared/feature-flags.ts b/src/main/webapp/app/shared/feature-flags.ts
@@ -0,0 +1 @@
+export const STOP_REVIEW_IF_CORE_SUBMISSION_FAILS: boolean = false;