Add mutations sorting by firebase index #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
reviewed
Sep 20, 2024
| @@ -46,6 +46,7 @@ export enum SortOptions { | |||
| LAST_MODIFIED = 'Last Modified', | |||
| POSITION_INCREASING = 'Position Increasing', | |||
| POSITION_DECREASING = 'Position Decreasing', | |||
| FIREBASE = 'Firebase', | |||
There was a problem hiding this comment.
I assume this will make the sort method returning 0 and it will use the order in the list?
zhx828
changed the title
jfkonecn
added a commit
that referenced
this pull request
Oct 3, 2024
* Handle when Instant json element is a json object The completedDate in the DB could be ISO 8601 string, or json object. I think this has to do with the recent spring boot upgrade, but I can't find the specific version of the change. I will handle both scenarios for now * Textarea in review mode should fit text content (#427) * Update pom version * Fix reject cancer type name review (#428) * Add reference to oncokb sop alteration nomenclature in add mutation modal helper (#432) * Update pom version * Avoid fetching management info repeatedly * Do not rerender the side bar when loading session The getSession is an async method which updates the loading status. * Fix drug code not selectable (#435) * Bump actions to latest version (#438) * resize text area when input changes (#440) * add sorting by firebase index (#443) * Delete mutation/tumor/treatment as last step to avoid stale index (#444) * Review no longer removes data for core submission * Added comments to useLastReviewOnly * Add children review paths * Fixed approve all * Fixed UI tests * Fixed UI tests * break in middle of word to fix collapsible title overlfow (#442) * Change searchEntities to readHandler instead of updateHandler (#445) * Fixed submit all * Fixed submission bug * Fixed data validation tool (#447) * Allow curating mutation summary (#433) * Fixed submit all * Fixed tests * Fixed gene type submissions * Removed last review check inside getevidences and gene type * Added mutation summary --------- Co-authored-by: Hongxin <[email protected]> Co-authored-by: Hongxin <[email protected]> Co-authored-by: Calvin Lu <[email protected]> Co-authored-by: oncokb-bot <[email protected]> Co-authored-by: bprize15 <[email protected]>
jfkonecn
added a commit
that referenced
this pull request
Oct 14, 2024
* Handle when Instant json element is a json object The completedDate in the DB could be ISO 8601 string, or json object. I think this has to do with the recent spring boot upgrade, but I can't find the specific version of the change. I will handle both scenarios for now * Textarea in review mode should fit text content (#427) * Update pom version * Fix reject cancer type name review (#428) * Add reference to oncokb sop alteration nomenclature in add mutation modal helper (#432) * Update pom version * Avoid fetching management info repeatedly * Do not rerender the side bar when loading session The getSession is an async method which updates the loading status. * Fix drug code not selectable (#435) * Bump actions to latest version (#438) * resize text area when input changes (#440) * add sorting by firebase index (#443) * Delete mutation/tumor/treatment as last step to avoid stale index (#444) * break in middle of word to fix collapsible title overlfow (#442) * Change searchEntities to readHandler instead of updateHandler (#445) * Fixed data validation tool (#447) * Allow curating mutation summary (#433) * Parse protein change case insensitive (#441) * Fix adding CDx biomarker association (#450) * use firebase properties directly in backend (#451) * fix references tab (#452) * Added Heap (#448) * Added Heap * Updated CSP * Reduce width so sidebar does not go offscren (#446) * allow comma in mutation name when transcripts present (#453) * allow comma in mutation name when transcripts present * add missing colon * rename transcripts to reference genomes * Make core API call non-blocking * Add tests for stale indices check (#455) * Added loading icon when review is accepted * Update setup-java action * Update pom version * Put feature flag in app config * Now showing loading icon on accept all --------- Co-authored-by: Hongxin <[email protected]> Co-authored-by: Hongxin <[email protected]> Co-authored-by: Calvin Lu <[email protected]> Co-authored-by: oncokb-bot <[email protected]> Co-authored-by: bprize15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.