Make core API call non-blocking #454
Conversation
The completedDate in the DB could be ISO 8601 string, or json object. I think this has to do with the recent spring boot upgrade, but I can't find the specific version of the change. I will handle both scenarios for now
Handle when Instant json element is a json object
The getSession is an async method which updates the loading status.
Avoid fetching management info repeatedly
* Added Heap * Updated CSP
* allow comma in mutation name when transcripts present * add missing colon * rename transcripts to reference genomes
Update setup-java action
| @@ -206,6 +206,7 @@ const ReviewPage: React.FunctionComponent<IReviewPageProps> = (props: IReviewPag | |||
| </Row> | |||
| </> | |||
| )} | |||
| {(isAcceptingAll || isAccepting) && <LoadingIndicator key={'curation-page-loading'} size={LoaderSize.LARGE} center isLoading />} | |||
There was a problem hiding this comment.
This is new to me. The loader is on top of the review page. What's your thought on this?
There was a problem hiding this comment.
Yes it's at the top. I have no real preference on this. You have a better eye for UI than I do.
There was a problem hiding this comment.
We could hide all review content when accepting all, and show a loader on the white background. Could you try that? Or without.
| @@ -0,0 +1 @@ | |||
| export const STOP_REVIEW_IF_CORE_SUBMISSION_FAILS: boolean = false; | |||
There was a problem hiding this comment.
I think you could make an argument either way for this. If you feel like you'll want to switch the behavior without creating a new build, then yes. If you feel like we'll make a code change first then rolls this out, then it doesn't make a different. This is entirely for myself to track the places I need to rollback.
There was a problem hiding this comment.
Let's move this to AppConfig to consolidate.
closes oncokb/oncokb-pipeline#569
I added the feature flag so I wouldn't miss a spot when I revert this change.
closes oncokb/oncokb-pipeline#570
I added a loading indicator as well.