Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Support migration for cub::{StoreDirectBlocked, StoreDirectStriped} API #1305

Closed

Conversation

abhilash1910
Copy link
Contributor

@abhilash1910 abhilash1910 commented Sep 15, 2023

Add Migration of cub::store API . Linked to #1819
cc @yihanwg , @zhimingwang36

@abhilash1910 abhilash1910 requested a review from a team as a code owner September 15, 2023 19:13
@abhilash1910 abhilash1910 marked this pull request as draft September 15, 2023 19:14
@abhilash1910 abhilash1910 changed the title [SYCLomatic] Support migration for cub::BlockLoad API [SYCLomatic] Support migration for cub::{StoreDirectBlocked, StoreDirectStriped} API Jul 11, 2024
@abhilash1910 abhilash1910 marked this pull request as ready for review July 11, 2024 14:15
@abhilash1910
Copy link
Contributor Author

Linked to #2094

@abhilash1910 abhilash1910 requested a review from yihanwg July 11, 2024 14:16
@@ -124,7 +123,6 @@ ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Rotate, Rotate, fals
ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Up, Up, false, NO_FLAG, P4, "Comment")
ENTRY_MEMBER_FUNCTION(cub::BlockShuffle, cub::BlockShuffle, Down, Down, false, NO_FLAG, P4, "Comment")


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove extra blank line change.

clang/lib/DPCT/APINames_CUB.inc Outdated Show resolved Hide resolved
@yihanwg
Copy link
Contributor

yihanwg commented Aug 13, 2024

Can you merge this PR into #1819?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants