Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] Block Load headers core #1640
[SYCLomatic] Block Load headers core #1640
Changes from all commits
bde928e
8717079
1549642
41d994e
99df7d9
789bd18
7872841
ec7a718
fe4c38e
a4e2316
1a0b447
c5e4fad
95edd0e
1419253
6f99026
eb5539a
8ce2b68
871c6c2
e8fc26e
0f7b5e4
93db62a
2d78e9a
1276698
8d43351
3d22cd7
0b32a44
e24ebb6
293bf14
721e722
a164256
0dc3fa0
59b881e
b6f123c
c0d96f5
5436755
118bcc1
7060821
aa6268a
48677b9
2e66d3c
70d5d27
7e50327
73aab25
f97e665
b90f7d9
fc0ce87
c788856
d4ce0b1
29d4405
a6a85ff
6ffd681
ee45991
7c8111d
a406b15
c4e125c
c3bc942
69dbddc
49f5d85
b1d8d70
7cefbf8
fdc2f2f
95db67f
141ace7
540db29
ebf6237
7f9d4e6
cb87b67
71d4047
bd24713
26a3ae2
6222566
236c7ba
89cf7d3
c4f0ca0
ec4f8ae
d382f60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename to nd_item? (what is the diff b/w Item and sycl::nd_item)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is same thing, but to maintain the same variable name across the file (similar for other apis), Item is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are quite many item usage, ITEM/Item/iterms/ITERMS_PER_WORK_ITEM, maybe it should give a better name for "typename Item", it is a little confusing. or please add comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks will add comments to clarify.