[SYCLomatic][PTX] Added support for prefetch ASM migration #2579
Conversation
clang/test/dpct/asm/prefetch.cu
Outdated
| // CHECK-NEXT: */ | ||
| asm volatile ("prefetch.local.L2 [%0];" : : "l"(arr)); | ||
| // CHECK: /* | ||
| // CHECK-NEXT: DPCT1053:{{.*}} Migration of device assembly code is not supported. |
There was a problem hiding this comment.
is there mapping? is no, how about we just remove it with DPCT warning.
There was a problem hiding this comment.
Yes, these is no mapping in SYCL except for global and generic addr space prefetching.
Do you suggest to remove the unsupported combination of prefetch instructions from migrated code?
There was a problem hiding this comment.
Yes, just removing it with an DPCT warnning.
There was a problem hiding this comment.
For this scenario, just return SYCLGenError(), no need to emit a warning msg, the current ASM migration framework will emit a warning msg for "SYCLGenError()" senario.
Proposing to retain this behavior upon suggestion from @tomflinda (ref)
There was a problem hiding this comment.
@TejaX-Alaghari
Pls prepare the E2E test firstly, for this E2E test,
It should cover the use scenarios for the PTX instruction we can support and the verification code for this PTX instruction, and it should be run passed with CUDA version
Then migrate the E2E test to SYCL version with mappings provided from SYCL side or help function, in doing so, we can verify whether the mappings we provided are correct.
Finally, we implement the migration logic in SYCLomatic, lit test from the E2E test, also E2E test should be submitted to SYCLomatic-test repo for this PTX instruction.
TejaX-Alaghari
force-pushed
the
ptx
branch
3 times, most recently
from
5ff4de2 to
3ed6837
Compare
TejaX-Alaghari
force-pushed
the
ptx
branch
2 times, most recently
from
eec848c to
758c8fb
Compare
TejaX-Alaghari
force-pushed
the
ptx
branch
2 times, most recently
from
4649e9c to
e742c34
Compare
Added support for prefetch PTX ASM migration
SYCL mapping is available under sycl_ext_oneapi_prefetch extension
Migrates syntax similar to here