Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend RFC announcement to include discussions #1742

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend RFC announcement to include discussions #1742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66c704
Extend announcement of RFCs to labeled discussions.
timmiesmith Jul 30, 2024
7eff968
Allow read of discussions.
timmiesmith Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/slack-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ on:
# use pull_request_target to run on PRs from forks and have access to secrets
pull_request_target:
types: [labeled]
# consider labeled discussions as well
discussion:
types: [labeled]

env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
channel: "onedpl"

permissions:
pull-requests: read
discussions: read

jobs:
rfc:
Expand Down
Loading