-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable copy-constructor and copy-assignment operations for the __future
class
#1859
base: main
Are you sure you want to change the base?
Conversation
4e27832
to
3fdf9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would resist making direct changes until we have had the chance to discuss this holistically in the context of the asynchronous API discussion.
It is a public (experimental) API, so we may want to wait and then change it only a single time, in a deliberate way (perhaps in the context of productization).
Unfortunately, not only (It is a public (experimental) API) : we widely using |
25f1ee1
to
770f606
Compare
…delete copy constructor from oneapi::dpl::__par_backend_hetero::__future class Signed-off-by: Sergey Kopienko <[email protected]>
…delete copy assignment from oneapi::dpl::__par_backend_hetero::__future class Signed-off-by: Sergey Kopienko <[email protected]>
…move parameters in oneapi::dpl::__par_backend_hetero::__future class constructors Signed-off-by: Sergey Kopienko <[email protected]>
… improvements + usage Signed-off-by: Sergey Kopienko <[email protected]>
…uture improvements : make code more compact Signed-off-by: Sergey Kopienko <[email protected]>
…nment Signed-off-by: Sergey Kopienko <[email protected]>
…modify the set of __future constructors Signed-off-by: Sergey Kopienko <[email protected]>
…ad copy) data into it Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
… special fix for __parallel_transform_reduce_work_group_kernel_submitter::operator() Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
…f auto" This reverts commit 6be8e44. Signed-off-by: Sergey Kopienko <[email protected]> # Conflicts: # include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce.h
770f606
to
3afc10c
Compare
Issue: #1776
What we change in this PR:
__future
: to be closet forstd::future
implementation and to avoid multiple resource (`sycl::event') owners;__future
constructors: in all use cases we able to movesycl::event
into the constructor instead of it's copy;__future
constructors: we passstd::tuple
into constructor by const reference or asr-value
;__make_future
functions: we declare it asstatic
and rewrite it to avoid extra data copy and use data move if possible.