Add CMake SYCL changes to oneDPLConfig.cmake.in #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbotaniuman
force-pushed
the
cmake-config-changes
branch
from
9a6f904 to
2bcf40f
Compare
dmitriy-sobolev
requested review from
dmitriy-sobolev,
mmichel11 and
adamfidel
There was a problem hiding this comment.
Thank you very much, @carbotaniuman. That's indeed an oversight.
Let me attach a patch to your changes:
dpl_config_fix.patch, where it is suggested:
Adding. Update: it is already there, no need to add it.CheckCXXCompilerFlagforcheck_cxx_compiler_flag- Adjusting the logic with
SYCL_SUPPORTand passing-fsycloption.
Besides that, the PR looks good to me.
|
Thank you for this patch. With @dmitriy-sobolev's minor suggestion, this PR looks good to me as well. |
This was copied over directly from CMakeLists.txt and is required for AdaptiveCPP to be recognized as a SYCL compiler.
carbotaniuman
force-pushed
the
cmake-config-changes
branch
from
2bcf40f to
da711c1
Compare
dmitriy-sobolev
approved these changes
Dec 12, 2024
mmichel11
approved these changes
Dec 12, 2024
|
@carbotaniuman once again, thanks for the PR. Feel free to submit a PR updating CREDITS.txt if you wish your contribution to be mentioned there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was copied over directly from CMakeLists.txt and is required for AdaptiveCPP to be recognized as a SYCL compiler. These changes were merged in #1949 so this appears to have been an oversight.