Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parallel_for_each scalability #1445

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

pavelkumbrasev
Copy link
Contributor

Description

This patch introduce scalability improvement for parallel_for_each using new approach with distributed reference counting.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
Copy link
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelkumbrasev pavelkumbrasev self-assigned this Jul 31, 2024
@pavelkumbrasev pavelkumbrasev merged commit fa237b9 into master Jul 31, 2024
22 checks passed
@pavelkumbrasev pavelkumbrasev deleted the dev/pavelkumbrasev/parallel_for_each_scale branch July 31, 2024 10:13
@phprus
Copy link
Contributor

phprus commented Jul 31, 2024

@pavelkumbrasev

CI error:

The following tests FAILED:
	 33 - test_buffer_node (Timeout)

https://github.com/oneapi-src/oneTBB/actions/runs/10178334232/job/28151751253

@pavelkumbrasev
Copy link
Contributor Author

I don't think it is related to parallel_for_each 😄
@kboyarinov could you please take a look?

@phprus
Copy link
Contributor

phprus commented Jul 31, 2024

@pavelkumbrasev , @kboyarinov
Could this be related to #1436 / #1281 ?

@kboyarinov
Copy link
Contributor

@phprus @pavelkumbrasev
The issue looks like a sporadic issue in the test. It should not be related to the PRs listed above.
@phprus, if by chance you have resources to take a look on that, we will appreciate this input.

@phprus
Copy link
Contributor

phprus commented Aug 4, 2024

@kboyarinov , @pavelkumbrasev
Issue with backtrace: #1467

kboyarinov pushed a commit that referenced this pull request Oct 1, 2024
---------

Signed-off-by: pavelkumbrasev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants