-
Notifications
You must be signed in to change notification settings - Fork 35
New docker UMF #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New docker UMF #1298
Conversation
@lukaszstolarczuk |
|
||
# Dependencies for tests (optional) | ||
ARG TEST_DEPS="\ | ||
libnuma-dev" | ||
libnuma-dev \ | ||
libtbb-dev\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scalable pool relies on TBB library (src/pool/pool_scalable.c
), so this is an UMF dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as for libnuma - as long as you don't use that pool it's not required. Hence, I'd leave as test deps.
|
||
# Dependencies for tests (optional) | ||
ARG TEST_DEPS="\ | ||
libnuma-dev" | ||
libnuma-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's requirement for OS memory provider, according to README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the readme, it's for testing :)
While I agree with you that for runtime this is a requirement, it is not the hard requirement. As long as you don't use that provider it's not really required, hence we only mark this as "for testing" (or, in the user's case - for the application that uses the provider).
I'd personally leave libnuma as test deps.
.github/workflows/reusable_basic.yml
Outdated
|
||
env: | ||
BUILD_DIR : "${{github.workspace}}/build" | ||
INSTL_DIR : "${{github.workspace}}/install-dir" | ||
INSTL_DIR : "${{github.workspace}}/../install-dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe going outside the workspace is not the best idea.
Added UMF docker
// workflow executed on fork:
https://github.com/rbanka1/unified-memory-framework/actions/runs/14862004849/job/41730405890
Checklist