Support versioning in git archives #1527
Open
+151
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
force-pushed
the
support-versioning-zip
branch
from
7a18f88 to
df3546f
Compare
Apparently this file speeds up process of AI contributions to this repository. It was fully generated by copilot.
While releasing UMF we should update VERSION file with the current version. It will be used only if git is not available or tags were not fetched. To underline it is not a "detailed version" we will add "-dev" in CMake version parsing, so it will stand out (comparing to e.g. versions like "1.0.3-dev1-...").
lukaszstolarczuk
force-pushed
the
support-versioning-zip
branch
from
df3546f to
3827282
Compare
| - Verify if scanners/linters/checkers passed | ||
| - Verify if version is set properly, especially in `.dll` and `.so` files | ||
| - Create/update a VERSION file for GitHub ZIP downloads (users without git): | ||
| - `echo "$VERSION" > VERSION` |
There was a problem hiding this comment.
hmm actually, wondering - should it be rather $VERSION+1...? This would align with our vX.X.X-devX approach (where main is introduced as next release)
There was a problem hiding this comment.
No, it has to be the correct version as this is included in a release (after this file edit, a tag is created).
PatKamin
reviewed
Sep 26, 2025
| ``` | ||
|
|
||
| ### Version Management | ||
| - Version determined by: 1) `git describe` (preferred), 2) `VERSION` file fallback, 3) "0.0.0" default |
There was a problem hiding this comment.
Make points multi-line for clarity
|
|
||
| ### Code Formatting | ||
| - **Always format code before committing**: `make format-apply` | ||
| - Requires build with `-DUMF_FORMAT_CODE_STYLE=ON` |
There was a problem hiding this comment.
Add this to a full features example above
| - Use `build_umf_test()` CMake function in `test/CMakeLists.txt` | ||
| - GPU tests require `UMF_BUILD_GPU_TESTS=ON` and hardware/drivers | ||
| - IPC tests use producer/consumer pattern with shell scripts | ||
| - Platform-specific tests: `.c` files for portability, `.cpp` for C++ features |
| - Platform-specific tests: `.c` files for portability, `.cpp` for C++ features | ||
|
|
||
| ### CI/CD Structure | ||
| - `pr_push.yml`: Main workflow calling reusable workflows |
There was a problem hiding this comment.
... called for each PR change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was almost fully done with Copilot (Agent Mode).
Fixes: #619