-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump UMF version and switch to dynamic linking #1430
Conversation
Let's target these changes for after 0.9. |
Sure, I just wanted to create a PR to do some initial testing |
068045f
to
ab7ce78
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
- Coverage 14.82% 12.49% -2.33%
==========================================
Files 250 239 -11
Lines 36220 36000 -220
Branches 4094 4086 -8
==========================================
- Hits 5369 4498 -871
- Misses 30800 31498 +698
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
664b7a1
to
beef35a
Compare
ddab02b
to
a3776e5
Compare
e4b1d3b
to
29d3e31
Compare
8462b60
to
fc40d13
Compare
108abe2
to
d15fe0d
Compare
@kbenzie we have confirmation that intel/llvm is ready for the change: intel/llvm#13343 (review) |
233c07c
to
c10ff81
Compare
and make a separate ur_umf interface library. This way, components that do not require UMF (e.g. loader) do not need to link with it.
as they require extra depndencies (libnuma)
c10ff81
to
0a259f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This patch does more than two things and has no description. Why are we switching to dynamic linking? Right now this patch does everything without rationale. Please split it more logically if you can, remove the fly-by changes, and provide us with a description of what justifies such changes |
Because that's how UMF is meant to ship with the compiler by default. This has been discussed with the compiler team.
We are switching to what will become UMF version for the next release.
All parts of this patch are required to bump up the UMF version. The actual code changes are all very minor fixes required for everything to compile after UMF interface changes. There are no cleanup or feature changes at all here. |
Testing PR for: oneapi-src/unified-runtime#1430 --------- Co-authored-by: Krzysztof Swiecicki <[email protected]> Co-authored-by: Steffen Larsen <[email protected]>
Testing PR for: oneapi-src/unified-runtime#1430 --------- Co-authored-by: Krzysztof Swiecicki <[email protected]> Co-authored-by: Steffen Larsen <[email protected]>
No description provided.