Hardening flags #2090
Merged
Hardening flags #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/cd
RossBrunton
force-pushed
the
ross/harden
branch
3 times, most recently
from
0024ae8
to
39103d7
Compare
github-actions
bot
added
the
specification
RossBrunton
force-pushed
the
ross/harden
branch
6 times, most recently
from
acd3f90
to
64ca4eb
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 20, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
64ca4eb
to
c069101
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 20, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 20, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 20, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
github-actions
bot
added
loader
RossBrunton
force-pushed
the
ross/harden
branch
from
3ffd955
to
f26c0ba
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 20, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
f26c0ba
to
8a5edfb
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 23, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
8a5edfb
to
cbd554e
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 23, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Sep 23, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
9133824
to
d210b7b
Compare
RossBrunton
changed the title
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
d210b7b
to
37e292a
Compare
RossBrunton
changed the title
RossBrunton
force-pushed
the
ross/harden
branch
2 times, most recently
from
46abcb5
to
b3c51b0
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
b3c51b0
to
56d3e34
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
56d3e34
to
0d61982
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
RossBrunton
force-pushed
the
ross/harden
branch
from
0d61982
to
12c79e2
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
kbenzie
approved these changes
Oct 8, 2024
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 8, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
kbenzie
reviewed
Oct 8, 2024
UR_DEVELOPER_MODE has also been changed to only set Werror. The previous other flags set by this variable either have no effect (-fno-omit-frame-pointer) or are now always enabled (-fstack-protector-strong). Some smaller warnings have also been fixed.
RossBrunton
force-pushed
the
ross/harden
branch
from
12c79e2
to
aa53a35
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Oct 9, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090
|
@oneapi-src/unified-runtime-level-zero-write Are you okay with this change? It's adding a bunch of "hardening" flags to the loader targets. |
We can do that, but it will only affect UR and intel/llvm builds. Normally the loader is shipped with the driver package. My (very slight) preference would be that we don't set any flags that might affect the performance or cause difference in behavior compared to the unmodified loader. |
pbalcer
approved these changes
Oct 10, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 14, 2024
Pre-merge commit for: oneapi-src/unified-runtime#2090 --------- Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_DEVELOPER_MODE has also been changed to only set Werror. The
previous other flags set by this variable either have no effect
(-fno-omit-frame-pointer) or are now always enabled
(-fstack-protector-strong).
Some smaller warnings have also been fixed.