Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTS] Skip images and fill2D tests if feature is not supported #2344

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[CTS] Skip images and fill2D tests if feature is not supported #2344

merged 2 commits into from
Dec 19, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Nov 18, 2024

No description provided.

@igchor igchor requested a review from a team as a code owner November 18, 2024 23:13
@github-actions github-actions bot added the conformance Conformance test suite issues. label Nov 18, 2024
@igchor igchor requested a review from a team as a code owner November 18, 2024 23:25
@github-actions github-actions bot added the level-zero L0 adapter specific issues label Nov 18, 2024
@igchor igchor changed the title [CTS] skip image tests if images are not supported Skip image tests if images are not supported and enable virtual mem for L0 v2 Nov 19, 2024
@igchor igchor force-pushed the skip_image_tests_if_not_supported branch 2 times, most recently from b73ecbe to 10d0f17 Compare November 20, 2024 21:26
@igchor igchor force-pushed the skip_image_tests_if_not_supported branch 3 times, most recently from 18e12b5 to ac78000 Compare December 5, 2024 17:30
@igchor igchor changed the title Skip image tests if images are not supported and enable virtual mem for L0 v2 [CTS] Skip images and fill2D tests if feature is not supported Dec 5, 2024
@igchor igchor force-pushed the skip_image_tests_if_not_supported branch from ac78000 to 580a6cd Compare December 5, 2024 18:43
@pbalcer
Copy link
Contributor

pbalcer commented Dec 11, 2024

Please run make cppformat.

@igchor igchor force-pushed the skip_image_tests_if_not_supported branch 2 times, most recently from d65c0ad to 8f8dec7 Compare December 11, 2024 21:53
@igchor igchor requested a review from a team as a code owner December 11, 2024 21:53
@github-actions github-actions bot added the native-cpu Native CPU adapter specific issues label Dec 11, 2024
@igchor igchor force-pushed the skip_image_tests_if_not_supported branch 2 times, most recently from fb17c95 to 1d3ea03 Compare December 11, 2024 22:16
@pbalcer
Copy link
Contributor

pbalcer commented Dec 13, 2024

@oneapi-src/unified-runtime-native-cpu-write please review

you need to rebase again :)

PietroGhg
PietroGhg approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, sorry for the late review

@igchor igchor force-pushed the skip_image_tests_if_not_supported branch from 1d3ea03 to 745efeb Compare December 13, 2024 17:55
@igchor
Copy link
Member Author

igchor commented Dec 13, 2024

@oneapi-src/unified-runtime-native-cpu-write please review

you need to rebase again :)

Done.

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Dec 16, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Dec 17, 2024

@igchor there's a conflict needing fixed on test/conformance/device/device_adapter_native_cpu.match

@igchor igchor force-pushed the skip_image_tests_if_not_supported branch from 745efeb to b13d49f Compare December 17, 2024 17:35
@igchor
Copy link
Member Author

igchor commented Dec 17, 2024

@igchor there's a conflict needing fixed on test/conformance/device/device_adapter_native_cpu.match

Rebased

@igchor
[NativeCPU] implement missing query for HOST_PIPE support
546652d 
and skip pipe and fill2d tests if the feature is not supported
@igchor igchor force-pushed the skip_image_tests_if_not_supported branch from b13d49f to 546652d Compare December 17, 2024 17:44
@martygrant martygrant merged commit d237393 into oneapi-src:main Dec 19, 2024
69 of 73 checks passed
martygrant added a commit to nrspruit/llvm that referenced this pull request Dec 19, 2024
@martygrant
[UR] Update tag to bb64b3e for PRs:
0c6636a 
- oneapi-src/unified-runtime#2476
- oneapi-src/unified-runtime#2425
- oneapi-src/unified-runtime#2344
- oneapi-src/unified-runtime#2471
@martygrant martygrant mentioned this pull request Dec 19, 2024
Merged
@martygrant
Copy link
Contributor

Pulled in by intel/llvm#16410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig left review comments

@PietroGhg PietroGhg PietroGhg approved these changes

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
conformance Conformance test suite issues. level-zero L0 adapter specific issues native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igchor @pbalcer @kbenzie @martygrant @aarongreig @PietroGhg