add a few missing Intel GPU device queries, fix device ID query #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, fix the device ID query
aarongreig
approved these changes
Dec 10, 2024
martygrant
added a commit
to bashbaug/llvm
that referenced
this pull request
Dec 13, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 13, 2024
…D query (#16299) see oneapi-src/unified-runtime#2437 --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few missing Intel GPU device queries, from the
cl_intel_device_attribute_queryextension:https://registry.khronos.org/OpenCL/extensions/intel/cl_intel_device_attribute_query.html
Also, adds the PCI address query, using
cl_khr_pci_bus_info:https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#cl_khr_pci_bus_info
Also, fixes the query for
UR_DEVICE_INFO_DEVICE_ID. This query should return the PCI device ID, not the PCI device number from the PCI bus info query. For now, the query uses the device ID query fromcl_intel_device_attribute_query, though this could be expanded to support similar queries from other vendors as well.