Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONEKEY baseline #79

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ONEKEY baseline #79

wants to merge 4 commits into from

Conversation

qkaiser
Copy link
Contributor

@qkaiser qkaiser commented May 13, 2023

Draft branch to establish a baseline for code quality and probably do some refactoring as mentioned in #75

@qkaiser qkaiser self-assigned this May 13, 2023
@qkaiser qkaiser marked this pull request as draft May 13, 2023 12:17
@qkaiser qkaiser mentioned this pull request Jun 2, 2023
Merged
@tnias
Copy link

tnias commented Jun 19, 2023

Not sure if this is the correct place to comment on this, but this looks like a cleanup and I thought it might fit. :)

The pyproject.toml (or the setup.py before) is very vague with license = "GNU GPL".

I found the following indicators:

  • LICENSE file is GPL-3.0
  • ubireader/ubi/defines.py: GPL-2.0-or-later
  • ubireader/ubifs/defines.py: GPL-2.0 (without clarification for "-only" or "-or-later")
  • all other non-empty python files had a GPL-3.0-or-later header

@qkaiser
Copy link
Contributor Author

qkaiser commented Jun 20, 2023

@tnias makes sense, thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@qkaiser qkaiser

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qkaiser @tnias