Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement full support for strict concurrency #2241

Merged
merged 47 commits into from
Apr 28, 2024
Merged

Implement full support for strict concurrency #2241

merged 47 commits into from
Apr 28, 2024

Commits on Mar 24, 2024

  1. Allow complete concurrency check and build test

    @onevcat
    onevcat committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    1cb171c View commit details
    Browse the repository at this point in the history

  2. Do not isolate all class since deinit has no opt in

    @onevcat
    onevcat committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    5d09c5e View commit details
    Browse the repository at this point in the history

  3. Isolate the Source Identifier 

    And remove unnecessary assertion
    @onevcat
    onevcat committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b2dc9fa View commit details
    Browse the repository at this point in the history

  4. Mark some types to sendable

    @onevcat
    onevcat committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    fc805d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Fix more possible Sendable warnings

    @onevcat
    onevcat committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    129a6b6 View commit details
    Browse the repository at this point in the history

  2. Refine sendable for some types

    @onevcat
    onevcat committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    fa53d26 View commit details
    Browse the repository at this point in the history

  3. Set back to minimal check

    @onevcat
    onevcat committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    5e0d1f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add necessary main actor

    @onevcat
    onevcat committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6213b7c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Add MainActor migration step

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    dc23ccb View commit details
    Browse the repository at this point in the history

  2. Fix compile warning and test errors for mac

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    584b0ff View commit details
    Browse the repository at this point in the history

  3. Fix for tvOS and watchOS

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    1943984 View commit details
    Browse the repository at this point in the history

  4. Assume isolate for deinit

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    420f6de View commit details
    Browse the repository at this point in the history

  5. Make ImageTransition Sendable

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    86e7bfa View commit details
    Browse the repository at this point in the history

  6. Mark protocols sendable

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    1680c9e View commit details
    Browse the repository at this point in the history

  7. Improve some test Sendable

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    b2a4506 View commit details
    Browse the repository at this point in the history

  8. Disk storage fully sendable

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    22863e0 View commit details
    Browse the repository at this point in the history

  9. Mark final to support Sendable

    @onevcat
    onevcat committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    8d8caf2 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Mark sendable for closures

    @onevcat
    onevcat committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    3bca097 View commit details
    Browse the repository at this point in the history

  2. Mark necessary types as Sendable

    @onevcat
    onevcat committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    e2ca7fb View commit details
    Browse the repository at this point in the history

  3. Cache can be sendable

    @onevcat
    onevcat committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    cd9f37f View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Mark manager class sendable

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2721186 View commit details
    Browse the repository at this point in the history

  2. Fix warning for image class

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bc11fd0 View commit details
    Browse the repository at this point in the history

  3. Mark ImageProgressive sendable

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a00caea View commit details
    Browse the repository at this point in the history

  4. Change image modifier as Sendable

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7fc722b View commit details
    Browse the repository at this point in the history

  5. Fix all warnings for target concurrency

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eb56be5 View commit details
    Browse the repository at this point in the history

  6. Verify and mark more sendable

    @onevcat
    onevcat committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    6e0f6bb View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Fix downloader concurrency issue

    @onevcat
    onevcat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    80f947d View commit details
    Browse the repository at this point in the history

  2. Fix more Sendable warnings

    @onevcat
    onevcat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3ad65f8 View commit details
    Browse the repository at this point in the history

  3. Sendable warnings for RetrievingContext

    @onevcat
    onevcat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f3e8d9c View commit details
    Browse the repository at this point in the history

  4. Fix retryContext and its tests for concurrency

    @onevcat
    onevcat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1605d11 View commit details
    Browse the repository at this point in the history

  5. Fix tests and temporarily mark main actor

    @onevcat
    onevcat committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    50b54c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Solve more warnings on Sendable

    @onevcat
    onevcat committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    441db82 View commit details
    Browse the repository at this point in the history

  2. Resolve more Sendable warnings and fix tests

    @onevcat
    onevcat committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5d2174d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Explicitly mark main queue helper block

    @onevcat
    onevcat committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    76425c5 View commit details
    Browse the repository at this point in the history

  2. KingfisherParsedOptionsInfo can be safe Sendable

    @onevcat
    onevcat committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3d7d2ce View commit details
    Browse the repository at this point in the history

  3. Make KFImage.Context as Sendable

    @onevcat
    onevcat committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    631c3c2 View commit details
    Browse the repository at this point in the history

  4. Fix test with isolated values

    @onevcat
    onevcat committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    10e5dbf View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Solve warnings for macOS target

    @onevcat
    onevcat committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    d4e29b4 View commit details
    Browse the repository at this point in the history

  2. Fix concurrency warnings for tvOS

    @onevcat
    onevcat committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    46389e5 View commit details
    Browse the repository at this point in the history

  3. Fix warnings for watchOS

    @onevcat
    onevcat committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    17d840d View commit details
    Browse the repository at this point in the history

  4. Mark SWIFT_STRICT_CONCURRENCY to complete

    @onevcat
    onevcat committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    d2aa3b6 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2239 from onevcat/concurrency/data-types 

    Strict concurrency is ready
    @onevcat
    onevcat authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    ef7bae9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fix compiling issue for Xcode 15.2

    @onevcat
    onevcat committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    553477c View commit details
    Browse the repository at this point in the history

  2. Append main actor to set image completion

    @onevcat
    onevcat committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5d686b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge branch 'v8' into fix/strict-concurrency

    @onevcat
    onevcat committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fe6ecd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Enable complete concurrency check for demo

    @onevcat
    onevcat committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0aee680 View commit details
    Browse the repository at this point in the history

  2. Update concurrency for watchOS app

    @onevcat
    onevcat committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e3d19ad View commit details
    Browse the repository at this point in the history