Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cadence Tutorials 1-6 to be more interactive and streamlined #172

Merged
merged 47 commits into from
Jan 24, 2025
Merged

Update Cadence Tutorials 1-6 to be more interactive and streamlined #172

merged 47 commits into from
Jan 24, 2025

Conversation

briandoyle81
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cadence-lang-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:00pm

@briandoyle81 briandoyle81 changed the title Make part 1 and 2 of Cadence Tutorial more interactive and streamlined Make part 1, 2, and 3 of Cadence Tutorial more interactive and streamlined Dec 4, 2024
@Aliserag Aliserag self-requested a review December 5, 2024 17:35
Aliserag
Aliserag reviewed Dec 5, 2024
View reviewed changes
turbolent
turbolent reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I mostly reviewed the changes in the language reference

@turbolent turbolent requested a review from a team December 9, 2024 18:16
@briandoyle81
Copy link
Contributor Author

Great work! I think these will be much better as new learning materials. I just got through resources so far, but just wanted to leave some comments to get you started on the changes. Also, in the preview, the link style you're using doesn't seem to work properly. Can you take a look? Not sure if that is just an issue with the preview or what

They are working for me in preview. It's possible one or two are broken or missing? I'll do a pass to check before merging

@briandoyle81 briandoyle81 mentioned this pull request Jan 24, 2025
Open
@briandoyle81 briandoyle81 changed the title Make part 1, 2, and 3 of Cadence Tutorial more interactive and streamlined Update Cadence Tutorials 1-6 to be more interactive and streamlined Jan 24, 2025
@briandoyle81 briandoyle81 added the Ready for Review This PR is ready for a comprehensive review or edit label Jan 24, 2025
@briandoyle81 briandoyle81 marked this pull request as ready for review January 24, 2025 21:30
joshuahannan
joshuahannan reviewed Jan 24, 2025
View reviewed changes
docs/tutorial/06-fungible-tokens.md Outdated

Execute `Get Balances` again.
Every Flow account is initialized with a default Flow Token Vault in order to pay for storage fees and transaction [fees]. If an address is use, it will be able to accept fees, without a user or developer needing to take further action. If that account becomes lost, any tokens inside will be lost as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they could delete it in a transaction, but after the transaction finishes executing, it would revert because it won't be able to provide any fees for the transaction or a minimum balance to cover storage fees, so it would never actually work.

joshuahannan
joshuahannan approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing everything! I'm okay with you merging once you've addressed the last few comments. And I trust that you've also updated the code in the links to include the changes to the code since the last time I reviewed. I did not verify and test them myself in the playground again this time

@briandoyle81 briandoyle81 merged commit ad68828 into main Jan 24, 2025
1 of 2 checks passed
@briandoyle81 briandoyle81 deleted the brian-doyle/content-updates-1 branch January 24, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent left review comments

@Aliserag Aliserag Aliserag left review comments

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees
No one assigned
Labels
Ready for Review This PR is ready for a comprehensive review or edit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@briandoyle81 @joshuahannan @turbolent @Aliserag @nialexsan