Change index expression's start position #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start position changed from opening square bracket to indexed expression's start position.
SupunS
reviewed
Sep 9, 2024
There was a problem hiding this comment.
First contribution! 👏 Thank you for opening a PR to fix this!
Looks like there are some tests failing, due to the updated position info. Can you please update those tests as well? https://github.com/onflow/cadence/actions/runs/10775433087/job/29882238324?pr=3575
You can also run make test from the root directory of the repo, to run all tests locally.
Clean up code, update tests to reflect changes.
turbolent
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #718
Description
This PR adds a test which throws an error involving index expression different from the type mismatch error addressed in #719. Index expression's start position was changed from opening square bracket to indexed expression's start position.
masterbranchFiles changedin the Github PR explorer