Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited string templates: $identifier #3585

Draft
wants to merge 8 commits into
base: feature/string-templates
Choose a base branch
from

Conversation

RZhang05
Copy link
Contributor

@RZhang05 RZhang05 commented Sep 19, 2024

Working towards #3579

Description

This PR introduces a simple string template in the form of the character $ followed by an identifier ("$foo"), with plans to support the syntax of $ followed by an expression in curly braces later.


  • Targeted PR against feature/string-templates branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@RZhang05
Copy link
Contributor Author

Opened for early feedback.

  • Need to add more tests across all stages of the feature
  • Implementation questions marked with STRINGTODO in the code
  • Further consider handling (or lack of handling) of error cases in the lexer and parser

@RZhang05 RZhang05 mentioned this pull request Sep 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant