Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #135

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Fix failing tests #135

merged 9 commits into from
Jul 31, 2023

Conversation

MaxStalker
Copy link
Contributor

Description

Current main branch have failing tests - some of them due to updated or moved contracts and some because of limitations of Flow emulator or lerna setup.

This PR targets to fix those issues.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from a team as a code owner July 29, 2023 22:23
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2023

⚠️ No Changeset found

Latest commit: 76c438e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MaxStalker
Copy link
Contributor Author

@jribbink can you merge this one into master, so I can rebase and update #134 ? :)

@jribbink jribbink merged commit cb4df8c into onflow:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants