Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence 1.0 #536

Merged
merged 41 commits into from
Dec 18, 2023
Merged

Update to Cadence 1.0 #536

merged 41 commits into from
Dec 18, 2023

Conversation

turbolent
Copy link
Member

Description

NOTE: This is a breaking change, master will not work with the currently deployed networks anymore.
See https://discord.com/channels/613813861610684416/1184982517774811137


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

SupunS and others added 30 commits July 24, 2023 16:24
Update to Cadence v1.0.0-preview.1
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Dec 15, 2023
@turbolent turbolent requested a review from a team December 15, 2023 21:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (473f20f) 53.27% compared to head (53d4cdd) 53.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   53.27%   53.26%   -0.02%     
==========================================
  Files          29       29              
  Lines        3872     3869       -3     
==========================================
- Hits         2063     2061       -2     
+ Misses       1655     1653       -2     
- Partials      154      155       +1     
Flag Coverage Δ
unittests 53.26% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@turbolent turbolent merged commit 9116c41 into master Dec 18, 2023
6 checks passed
@turbolent turbolent deleted the feature/stable-cadence branch December 18, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants