Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Access] Subscribe endpoints is missing #593

Merged
merged 4 commits into from
Mar 13, 2024
Merged

[Access] Subscribe endpoints is missing #593

merged 4 commits into from
Mar 13, 2024

Conversation

UlyanaAndrukhiv
Copy link

@UlyanaAndrukhiv UlyanaAndrukhiv commented Mar 6, 2024 •
edited
Loading

FLIP: onflow/flips#229
Connected with onflow/flow-go#5307

Description

This pull request :

  • updated flow/protobuf/go/flow , implemened missing SubscribeBlocks, SubscribeBlockHeaders and SubscribeBlockDigests methods from Access API interface.
  • updated RegisterAccessAPIServer, StateStreamBackend and updated creating backend.Config according to new flow-go package version.

@UlyanaAndrukhiv
Added SubscribeBlocks, SubscribeBlockHeaders, SubscribeBlockDigests a…
d71cdea 
…ccording to new Access API, updated according to new flow-go version
@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this pull request Mar 6, 2024
Merged
@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as draft March 6, 2024 12:50
@UlyanaAndrukhiv UlyanaAndrukhiv mentioned this pull request Mar 7, 2024
Closed
@peterargue peterargue marked this pull request as ready for review March 13, 2024 17:40
peterargue
peterargue approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

To roll this out, we will need to first merge this with the import replace, then merge the flow-go PR, and finally open a new PR updating the flow-go version

@peterargue peterargue merged commit 1d05170 into onflow:release/v0 Mar 13, 2024
This was referenced Mar 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue approved these changes

@sideninja sideninja Awaiting requested review from sideninja sideninja is a code owner

@turbolent turbolent Awaiting requested review from turbolent turbolent is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlyanaAndrukhiv @peterargue