Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implemented options to fail or warn when payer is not able to pay #744

Conversation

Guitarheroua
Copy link
Collaborator

onflow/flow-go#6139

Added implementation of PayerBalanceMode to control whether transaction validation should fail or warn when the payer is not able to pay.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.54%. Comparing base (3f120d3) to head (a68bcda).
Report is 148 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3f120d3) and HEAD (a68bcda). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3f120d3) HEAD (a68bcda)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #744       +/-   ##
===========================================
- Coverage   51.24%   35.54%   -15.70%     
===========================================
  Files          34       47       +13     
  Lines        4533     7370     +2837     
===========================================
+ Hits         2323     2620      +297     
- Misses       2027     4561     +2534     
- Partials      183      189        +6     
Flag Coverage Δ
unittests 35.54% <100.00%> (-15.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua changed the title Added check payer balance mode [Access] Implemented options to fail or warn when payer is not able to pay Sep 3, 2024
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go from my side when the replace is removed

@Guitarheroua
Copy link
Collaborator Author

Created new one from repo, not a fork #756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants