Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update previewnet deployment #100

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jul 30, 2024

Description

  • Updates Previewnet deployment address in flow.json & README
  • Updates EVM.cdc with current fvm/evm/stdlib/contract.cdc in flow-go
  • Fixes failing test case

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added the Deployment Requires contract deployment or update label Jul 30, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Jul 30, 2024
@sisyphusSmiling sisyphusSmiling added the Documentation Improvements or additions to documentation label Jul 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (02aab3f) to head (be5f7fd).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   86.19%   86.33%   +0.13%     
==========================================
  Files          18       17       -1     
  Lines         884      922      +38     
==========================================
+ Hits          762      796      +34     
- Misses        122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review July 30, 2024 23:06
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner July 30, 2024 23:06
@sisyphusSmiling sisyphusSmiling merged commit 62aa778 into main Aug 5, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the update-previewnet-deployment branch August 5, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Requires contract deployment or update Documentation Improvements or additions to documentation
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants