Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet deployment followup #107

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Aug 14, 2024

Closes: #102

Description

  • Updates deployment script addressing issues during Testnet deployment
  • Updates flow.json aliases
  • Adds Testnet deployment addresses to README

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added the Deployment Requires contract deployment or update label Aug 14, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Aug 14, 2024
@sisyphusSmiling
Copy link
Contributor Author

cc @bthaile @nialexsan for changes related to Flow Port

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review August 14, 2024 20:41
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner August 14, 2024 20:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (8623710) to head (0c2899f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          17       17           
  Lines         922      922           
=======================================
  Hits          796      796           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit a9d52f9 into main Aug 19, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the testnet-deployment-followup branch August 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Requires contract deployment or update
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[DEPLOYMENT] Deploy & Configure Bridge on Testnet post-migration
3 participants