Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Crescendo updates #120

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Post-Crescendo updates #120

merged 10 commits into from
Sep 10, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Sep 7, 2024

Description

  • Adds Mainnet deployment addresses to README
  • Updates flow.json to remove deprecated networks and leverage dependency manager
  • Adds util transactions & scripts
  • Updates Cadence-related CI commands for new Flow CLI version
  • Fix the emulator EVMBridgedNFTTemplate import
  • Fix json Cadence arg values

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (7d4a2ff) to head (e5aa113).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files          18       18           
  Lines         955      955           
=======================================
  Hits          829      829           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review September 7, 2024 02:41
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner September 7, 2024 02:41
@sisyphusSmiling sisyphusSmiling merged commit 8c83149 into main Sep 10, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the post-crescendo-updates branch September 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants