Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evm onboarding blocklist functionality #123

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Sep 19, 2024

Closes: #122

Description

  • Adds an EVMBlocklist resource managed within FlowEVMBridgeConfig which allows the Admin to set, update, and remove blocklist status

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added Improvement Deployment Requires contract deployment or update labels Sep 19, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (8c83149) to head (305571f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   86.80%   86.95%   +0.15%     
==========================================
  Files          18       18              
  Lines         955      966      +11     
==========================================
+ Hits          829      840      +11     
  Misses        126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review September 19, 2024 17:44
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner September 19, 2024 17:44
@sisyphusSmiling sisyphusSmiling merged commit af98c38 into main Sep 19, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the add-evm-blocklist branch September 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Requires contract deployment or update Improvement
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add EVM contract onboarding blocklist
3 participants