Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFT contract templates #83

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Fix NFT contract templates #83

merged 6 commits into from
Jun 7, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jun 5, 2024

Closes: #82

Description

Updates the NFT template across networks (redundantly included due to the need for static import declarations). These updates are then reflected in the Cadence JSON arguments as code chunks reflective of the contract changes.
Also adds queries to determine if an account is configured to receive a specified vault or NFT.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling changed the title Fix templates Fix NFT contract templates Jun 5, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Jun 5, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review June 5, 2024 21:35
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner June 5, 2024 21:35
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (02aab3f) to head (45f058f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          18       18           
  Lines         884      884           
=======================================
  Hits          762      762           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have tests for these new transactions?

@sisyphusSmiling
Copy link
Contributor Author

I just wired up the vault & collection inspection scripts to tests. The storage iteration script to gather token info wasn't covered as I need to get some other changes in for the weekend. It's not mutating - purely informational - but could afford to add coverage in the future.

@sisyphusSmiling sisyphusSmiling merged commit efd99b1 into main Jun 7, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the fix-templates branch June 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Syntax error in Previewnet NFT template
4 participants