Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FlowEVMBridgeConfig.setGasLimit() transaction & test coverage #92

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jun 26, 2024

Closes: #91


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (02aab3f) to head (f069065).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   86.19%   86.31%   +0.12%     
==========================================
  Files          18       17       -1     
  Lines         884      921      +37     
==========================================
+ Hits          762      795      +33     
- Misses        122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review June 26, 2024 17:00
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner June 26, 2024 17:00
@sisyphusSmiling sisyphusSmiling merged commit 8e04119 into main Jul 1, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the add-gas-setting-txn branch July 1, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add gas setting transaction
3 participants