cover all actions with tests

onflow · Dec 11, 2024 · b62f8db · b62f8db
1 parent 665cdb0
commit b62f8db
Show file tree

Hide file tree

Showing 2 changed files with 405 additions and 24 deletions.
diff --git a/engine/access/rest/websockets/controller.go b/engine/access/rest/websockets/controller.go
@@ -18,6 +18,10 @@ import (
 	"github.com/onflow/flow-go/utils/concurrentmap"
 )
 
+var (
+	ErrUnmarshalMessage = errors.New("failed to unmarshal message")
+)
+
 type Controller struct {
 	logger zerolog.Logger
 	config Config
@@ -260,7 +264,7 @@ func (c *Controller) handleUnsubscribe(ctx context.Context, msg models.Unsubscri
 
 	provider, ok := c.dataProviders.Get(id)
 	if !ok {
-		c.writeBaseErrorResponse(ctx, err, "unsubscribe")
+		c.writeBaseErrorResponse(ctx, fmt.Errorf("could not find data provider with such id"), "unsubscribe")
 		c.logger.Debug().Err(err).Msg("no active subscription with such ID found")
 		return
 	}
@@ -295,6 +299,7 @@ func (c *Controller) handleListSubscriptions(ctx context.Context) {
 	resp := models.ListSubscriptionsMessageResponse{
 		BaseMessageResponse: models.BaseMessageResponse{
 			Success: true,
+			Action:  "list_subscriptions",
 		},
 		Subscriptions: subs,
 	}