Fixed broken integration tests for DKG

onflow · Dec 2, 2024 · bea9c1a · bea9c1a
1 parent 62d399d
commit bea9c1a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/integration/dkg/dkg_emulator_test.go b/integration/dkg/dkg_emulator_test.go
@@ -136,9 +136,8 @@ func (s *EmulatorSuite) runTest(goodNodes int, emulatorProblems bool) {
 	signatures := []crypto.Signature{}
 	indices := []int{}
 	for i, n := range nodes {
-		beaconKey, safe, err := n.dkgState.RetrieveMyBeaconPrivateKey(nextEpochSetup.Counter)
+		beaconKey, err := n.dkgState.UnsafeRetrieveMyBeaconPrivateKey(nextEpochSetup.Counter)
 		require.NoError(s.T(), err)
-		require.True(s.T(), safe)
 
 		signature, err := beaconKey.Sign(sigData, hasher)
 		require.NoError(s.T(), err)

diff --git a/integration/dkg/dkg_whiteboard_test.go b/integration/dkg/dkg_whiteboard_test.go
@@ -295,9 +295,8 @@ func TestWithWhiteboard(t *testing.T) {
 	signatures := []crypto.Signature{}
 	indices := []int{}
 	for i, n := range nodes {
-		beaconKey, safe, err := n.dkgState.RetrieveMyBeaconPrivateKey(nextEpochSetup.Counter)
+		beaconKey, err := n.dkgState.UnsafeRetrieveMyBeaconPrivateKey(nextEpochSetup.Counter)
 		require.NoError(t, err)
-		require.True(t, safe)
 
 		signature, err := beaconKey.Sign(sigData, hasher)
 		require.NoError(t, err)

diff --git a/integration/dkg/node.go b/integration/dkg/node.go
@@ -4,8 +4,6 @@ import (
 	"crypto"
 	"testing"
 
-	"github.com/stretchr/testify/require"
-
 	sdk "github.com/onflow/flow-go-sdk"
 	sdkcrypto "github.com/onflow/flow-go-sdk/crypto"
 	"github.com/onflow/flow-go/engine/consensus/dkg"
@@ -53,8 +51,6 @@ func (n *node) Ready() <-chan struct{} {
 }
 
 func (n *node) Done() <-chan struct{} {
-	require.NoError(n.t, n.PublicDB.Close())
-	require.NoError(n.t, n.SecretsDB.Close())
 	return util.AllDone(n.messagingEngine, n.reactorEngine)
 }