Add migration to add a key to all service accounts #6096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/atree-inlining-cadence-v1.0 #6096 +/- ##
=======================================================================
+ Coverage 41.64% 43.71% +2.06%
=======================================================================
Files 1974 1771 -203
Lines 139562 121059 -18503
=======================================================================
- Hits 58125 52924 -5201
+ Misses 75411 62688 -12723
+ Partials 6026 5447 -579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
changed the base branch from
master
to
feature/atree-inlining-cadence-v1.0
fxamacker
reviewed
Jun 20, 2024
Comment on lines
564
to
567
| migrators.NewAddKeyMigration( | ||
| opts.ChainID, | ||
| key, | ||
| ), |
There was a problem hiding this comment.
Do we want to move new migration AddKeyMigration before AccountUsageMigration since it adds public key to accounts?
fxamacker
approved these changes
Jun 26, 2024
turbolent
reviewed
Jun 26, 2024
| chainID := flow.Emulator | ||
| sc := systemcontracts.SystemContractsForChain(chainID) | ||
|
|
||
| serviceRegisters := registersByAccount.AccountRegisters(string(sc.FlowServiceAccount.Address.Bytes())) |
There was a problem hiding this comment.
Maybe factor the repeated sc.FlowServiceAccount.Address into a variable
janezpodhostnik
force-pushed
the
janez/migration-mainnet-add-keys-to-core-contracts
branch
from
710bd3d
to
14e2bc4
Compare
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do Not Merge
This is an extra migration that adds a public key to all service accounts. The intended usage is for testing the migration of mainnet. This allows us to run transactions on the test migrated mainnet network to setup networking addresses and epoch related state.