-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tools] Add a script to move checkpoint files #6143
Conversation
97c8024
to
e3fbd74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6143 +/- ##
==========================================
- Coverage 41.63% 41.63% -0.01%
==========================================
Files 1973 1973
Lines 139355 139355
==========================================
- Hits 58026 58023 -3
+ Misses 75313 75311 -2
- Partials 6016 6021 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Oh, good catch |
e3fbd74
to
84cc998
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Just ideas (feel free to ignore):
- maybe add a flag to use
mv -i
(for extra safety when used interactively) - maybe use
sha256sum
in the script to confirm all the files didn't get modified/corrupted
cf910ae
to
9addef4
Compare
Good point. I added a
I'd like to keep the script simple for moving files around, the checksum should be done by separate tools. |
Co-authored-by: Janez Podhostnik <[email protected]>
05b96bc
to
cebdce6
Compare
This PR adds a tool to move checkpoint files. It does both moving and renaming.
See the following example: