Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable test TestProtocolVersionUpgrade #6752

Open
wants to merge 7 commits into
base: jord/6622-chunk-service-events
Choose a base branch
from

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 21, 2024

We implemented TestProtocolVersionUpgrade as part of the original work around the Protocol KVStore, but disabled it until the corresponding smart contract change was ready to deploy to Mainnet. That smart contract change is now merged to the core-contracts feature branch, onflow/flow-core-contracts#465, to be deployed alongside EFM Recovery.

This PR re-enables the test.

  • The smart contract implementation has been modified since this test was first written to emit the service event immediately (not in a system chunk)
  • This PR enables require-approvals=1 and extends Chunk Data Model supports per-chunk service event mapping #6744, which implements a solution for verifying service events outside the system chunk.

@jordanschalm jordanschalm marked this pull request as ready for review November 21, 2024 20:43
@AlexHentschel
Copy link
Member

Just came across this details while reviewing:

func (model *Modelv0) SetEpochExtensionViewCount(viewCount uint64) error {
// Strictly speaking it should be perfectly fine to use a value viewCount >= model.FinalizationSafetyThreshold.
// By using a sligtly higher value(factor of 2) we ensure that extension is big enough in practice to give operators a bigger
// window in which a valid epoch recover event could be submitted.

technically, the operators don't submit the epoch recovery transaction - it is the human governance committee. Would you mind updating the documentation (including the typo in sligtly):

// Strictly speaking it should be perfectly fine to use a value viewCount >= model.FinalizationSafetyThreshold.
// By using a slightly higher value (factor of 2), we ensure that each extension spans a sufficiently big time 
// window for the human governance committee to submit a valid epoch recovery transaction. 

Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants