Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport v0.33 upgrade go to v1.22 #6811

Closed
wants to merge 11 commits into from
Closed

Backport v0.33 upgrade go to v1.22 #6811

wants to merge 11 commits into from

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Dec 12, 2024 •
edited
Loading

Backport #6037 to v0.33

Otherwise, the build will fail.

@zhangchiqing zhangchiqing mentioned this pull request Dec 12, 2024
Closed
janezpodhostnik
janezpodhostnik approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disclaimer: This is huge, but its mostly generated code. I think I checked all the non-generated files, but not sure. I might have scrolled past some.

@zhangchiqing
Copy link
Member Author

Close as I can build the util from branch leo/v0.33-verify-execution-result-with-go-20 without passing the CI build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@fxamacker fxamacker fxamacker approved these changes

@peterargue peterargue Awaiting requested review from peterargue peterargue is a code owner

@tarakby tarakby Awaiting requested review from tarakby tarakby is a code owner

@AlexHentschel AlexHentschel Awaiting requested review from AlexHentschel AlexHentschel is a code owner

@durkmurder durkmurder Awaiting requested review from durkmurder durkmurder is a code owner

@jordanschalm jordanschalm Awaiting requested review from jordanschalm jordanschalm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangchiqing @fxamacker @janezpodhostnik @turbolent