Skip to content

Commit

Permalink
expand comments
Browse files Browse the repository at this point in the history
  • Loading branch information
janezpodhostnik committed Aug 21, 2024
1 parent 49e4f71 commit 94f0398
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
7 changes: 5 additions & 2 deletions protobuf/flow/execution/execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ service ExecutionAPI {
returns (BlockHeaderResponse);

// GetTransactionExecutionMetricsAfter gets the transaction execution metrics
// for blocks after the given block height.
// for blocks after the given block height. The blocks will be sorted by
// descending block height.
// If no data is available for the given block height, the response will be
// empty. The execution node will only store metrics for a limited number of
// blocks,  so the request may return an empty response if the requested
Expand Down Expand Up @@ -234,6 +235,7 @@ message BlockHeaderResponse {
// The request for GetTransactionExecutionMetricsAfter
message GetTransactionExecutionMetricsAfterRequest {
// Block height after which to get transaction execution metrics.
// this block height will not be included in the response.
uint64 block_height = 1;
}

Expand Down Expand Up @@ -270,6 +272,7 @@ message GetTransactionExecutionMetricsAfterResponse {
repeated Transaction transactions = 2;
}

// a list of results for each block
// a list of results for each block sorted by block height in
// descending order
repeated Result results = 1;
}
4 changes: 3 additions & 1 deletion protobuf/go/flow/execution/execution.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions protobuf/go/flow/execution/execution_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 94f0398

Please sign in to comment.